alloc: Document panics when allocations will exceed max #148662
+24
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
This comment has been minimized.
This comment has been minimized.
Author
|
At a glance, the build failures appear to be related to CI setup and not to these changes. |
Contributor
|
CI is currently broken, it should be fixed once #148665 is merged. |
leftmostcat
force-pushed
the
document-isize-limit
branch
from
7528a5b to
7c84655
Compare
This comment has been minimized.
This comment has been minimized.
joboet
requested changes
Nov 13, 2025
library/alloc/src/string.rs
Outdated
| /// | ||
| /// # Panics | ||
| /// | ||
| /// Panics if the new capacity exceeds `isize::MAX` _bytes_. |
Member
There was a problem hiding this comment.
There isn't an old capacity here.
Suggested change
| /// Panics if the new capacity exceeds `isize::MAX` _bytes_. | |
| /// Panics if the capacity exceeds `isize::MAX` _bytes_. |
Author
There was a problem hiding this comment.
I do prefer the suggested wording. Presently, Vec uses the "new capacity" phrasing; should I adjust that as well?
rustbot
added
S-waiting-on-author
leftmostcat
force-pushed
the
document-isize-limit
branch
from
7c84655 to
5a8cf33
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document panics in
StringandVecdue to capacity overflowingisize::MAX. Correct outdated claims ofusize::MAXlimit.Fixes #148598.
Ping @lolbinarycat